Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: force Apache proxy on upgrade ......................................................................
Patch Set 2: (2 inline comments) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 211: help=output_messages.INFO_CONF_PARAMS_HTTPS_PORT_USAGE, Line 212: action='store', Line 213: dest='https', Line 214: default='443' Line 215: ) Again, I do not really understand why the above is required... can you please explain? I may missing something. Do you intend to allow admin to overwrite the port? But if it is on non standard number you overwrite whatever user specified... And if user specify here something you do not change apache configuration... no? Line 216: Line 217: (options, args) = parser.parse_args() Line 218: return (options, args) Line 219: Line 1251: def updateHttpdConf(): Line 1252: """ Line 1253: Update httpd configuration forcing proxy on upgrade. Line 1254: """ Line 1255: srv = utils.Service(basedefs.HTTPD_SERVICE_NAME) I would have have moved all the stop/start to the same place bellow. Line 1256: srv.stop(False) Line 1257: if os.path.exists(basedefs.FILE_OVIRT_HTTPD_CONF_LEGACY): Line 1258: os.rename( Line 1259: basedefs.FILE_OVIRT_HTTPD_CONF_LEGACY, -- To view, visit http://gerrit.ovirt.org/15051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
