Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: force Apache proxy on upgrade ......................................................................
Patch Set 2: (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 211: help=output_messages.INFO_CONF_PARAMS_HTTPS_PORT_USAGE, Line 212: action='store', Line 213: dest='https', Line 214: default='443' Line 215: ) Well I wanted to allow the admin to set http and https port during the upgrade if previously the proxy was disabled. If previously the proxy was enabled, I just use existing settings. If it wasn't previously enabled I suppose that the admin was using something over 1024 as http and https ports. So I've left a "workaround" for the admin to set the same ports he used previously during the upgrade. Both parameters are optional and if the admin doesn't say anything and the ports are free, default values will be used. But I've no objections on removing it if you think it is useless. Line 216: Line 217: (options, args) = parser.parse_args() Line 218: return (options, args) Line 219: -- To view, visit http://gerrit.ovirt.org/15051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib46bcf40acff860cd3e52634ade683d7a8836cf6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
