Liron Ar has posted comments on this change.
Change subject: core: allow hibernate for vm without image disks (#928708)
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
Line 238: // {
Line 239: // retValue = false;
Line 240: //
ReturnValue.CanDoActionMessages.Add(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW.toString());
Line 241: // }
Line 242: else if (getStorageDomainId().equals(Guid.Empty)) {
suggestion - don't we want to have that check "later"?
after this change, the first message that the user will get is related to space
check - which might be a bit annoying (going to free some space for example,
just to find out that we can't do the action because of more "trivial" issue).
Line 243:
addCanDoActionMessage(VdcBllMessages.VM_CANNOT_SUSPEND_NO_SUITABLE_DOMAIN_FOUND);
Line 244: retValue = false;
Line 245: } else {
Line 246: if (getVm().getStatus() == VMStatus.WaitForLaunch ||
getVm().getStatus() == VMStatus.NotResponding) {
--
To view, visit http://gerrit.ovirt.org/13395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
