Omer Frenkel has posted comments on this change.
Change subject: core: allow hibernate for vm without image disks (#928708)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
Line 66: */
Line 67: @Override
Line 68: public NGuid getStorageDomainId() {
Line 69: if (_storageDomainId.equals(Guid.Empty) && getVm() != null) {
Line 70: VmHandler.updateDisksFromDb(getVm());
seems that its not needed, will send a different patch for that, as its not
related to this bug
Line 71: List<StorageDomain> domainsInPool =
getStorageDomainDAO().getAllForStoragePool(getVm().getStoragePoolId());
Line 72: if (domainsInPool.size() > 0) {
Line 73: for (StorageDomain currDomain : domainsInPool) {
Line 74: if
((currDomain.getStorageDomainType().equals(StorageDomainType.Master)
Line 263
Line 264
Line 265
Line 266
Line 267
Done
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 835: ACTION_TYPE_FAILED_SERVER_NAME_REQUIRED=Cannot ${action} ${type}.
Server Name required.
Line 836: SERVER_ALREADY_EXISTS_IN_ANOTHER_CLUSTER=One or more servers are
already part of an existing cluster.
Line 837: SSH_AUTHENTICATION_FAILED=SSH Authentication failed. Please make sure
password is correct.
Line 838: =======
Line 839: CANNOT_HIBERNATE_NO_SUITABLE_DOMAIN_FOUND=Cannot Hibernate VM, No
active data Storage Domain with enough storage was found in the Data Center.
Done
Line 840: # External Events Errors Messages
Line 841: VAR__TYPE__EXTERNAL_EVENT=$type External Event
Line 842: ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN=Cannot ${action}
${type}. Illegal Origin for External Event : oVirt
Line 843: ACTION_TYPE_FAILED_EXTERNAL_EVENT_NOT_FOUND=Cannot ${action}
${type}.External Event does not exist.
--
To view, visit http://gerrit.ovirt.org/13395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
