Allon Mureinik has posted comments on this change.
Change subject: core: allow hibernate for vm without image disks (#928708)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Can't see the bug description since bugzilla is down for maintenance, but looks
OK.
Will upgrade my review to +2 once Liron's comments are addressed and I can
verify vs. bugzilla that this fix indeed addresses the issue.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
Line 66: */
Line 67: @Override
Line 68: public NGuid getStorageDomainId() {
Line 69: if (_storageDomainId.equals(Guid.Empty) && getVm() != null) {
Line 70: VmHandler.updateDisksFromDb(getVm());
why is this needed?
Line 71: List<StorageDomain> domainsInPool =
getStorageDomainDAO().getAllForStoragePool(getVm().getStoragePoolId());
Line 72: if (domainsInPool.size() > 0) {
Line 73: for (StorageDomain currDomain : domainsInPool) {
Line 74: if
((currDomain.getStorageDomainType().equals(StorageDomainType.Master)
--
To view, visit http://gerrit.ovirt.org/13395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
