Allon Mureinik has posted comments on this change.
Change subject: core: allow hibernate for vm without image disks (#928708)
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Minor grammer issue, please fix in all the AppErrors.properties files.
Will give +2 when bugzilla is back up again so I can verify this patch indeed
does what's expected.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 307: ACTION_TYPE_FAILED_VM_TASKS_ARE_ALREADY_RUNNING=Cannot ${action}
${type}. There are already asynchronous running tasks, please retry later.
Line 308: VM_CANNOT_SUSPENDE_HAS_RUNNING_TASKS=Cannot suspend VM. VM has
asynchronous running tasks, please retry later.
Line 309: VM_CANNOT_SUSPEND_STATELESS_VM=Cannot suspend VM, VM is stateless.
Line 310: VM_CANNOT_SUSPEND_VM_FROM_POOL=Cannot suspend VM that belongs to a
VM-Pool.
Line 311: VM_CANNOT_SUSPEND_NO_SUITABLE_DOMAIN_FOUND=Cannot suspend VM, No
active data Storage Domain with enough storage was found in the Data Center.
Either put a full stop(.) instead of a comma(,) after "Cannot suspend VM", or
replace "No" with "no".
Line 312: USER_NOT_AUTHORIZED_TO_PERFORM_ACTION=User is not authorized to
perform this action.
Line 313: ERROR_CANNOT_REMOVE_ROLE_ATTACHED_TO_PERMISSION=One or more
Permissions is still associated with Role.\n\
Line 314: - Please remove all Permissions first.
Line 315: ERROR_CANNOT_REMOVE_ROLE_INVALID_ROLE_ID=Cannot remove Role, invalid
Role id.
--
To view, visit http://gerrit.ovirt.org/13395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
