Allon Mureinik has posted comments on this change. Change subject: core: allow hibernate for vm without image disks (#928708) ......................................................................
Patch Set 4: Looks good to me, but someone else must approve *today*, before this patch, we select a domain at random, and may even fail afterwards if the domain we chose does not have sufficient space. I like the way this patch is going: 1. It eliminates a potential bug by select a domain we know has enough space (albeit this decision is racy by definition) 2. It eliminates a fictitious limitation that makes no sense in the user's mind Perhaps we should introduce some better algorithm to select the "cheapest" storage, the one with the most free space, the one with the least volumes or the one who's name starts with pleaseUseMe, but I agree with Omer - I don't think it's related to THIS patch. -- To view, visit http://gerrit.ovirt.org/13395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
