Yair Zaslavsky has posted comments on this change.
Change subject: gluster: added cluster level check
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
Line 165: result = validateMetrics();
Line 166: }
Line 167:
Line 168: if (getVdsGroup().supportsGlusterService()
Line 169: &&
!GlusterFeatureSupported.gluster(getVdsGroup().getcompatibility_version())) {
Shireesh, how will you distinguish if a certain gluster feature is supported
at version X, and another gluster feature is not supported at version X ?
With FeatureSupported you have the "feature names" at the static methods.
Line 170:
addCanDoActionMessage(VdcBllMessages.GLUSTER_NOT_SUPPORTED);
Line 171:
addCanDoActionMessage(String.format("$compatibilityVersion %1$s",
getVdsGroup().getcompatibility_version().getValue()));
Line 172: result = false;
Line 173: }
--
To view, visit http://gerrit.ovirt.org/12970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
