Shireesh Anjal has posted comments on this change. Change subject: gluster: added cluster level check ......................................................................
Patch Set 9: Yair, I don't think it is good to create a separate patch with the vdc_config entries alone, as they are incomplete without the code that uses them. The best I can do is: a) Changes in FeatureSupported mechanism (includes renaming FeatureSupported to VirtFeatureSupported and the new utility class CompatibilityUtils with only one utility method). This will result in lot of virt related sources also changing in the same patch. b) Introduction of GlusterFeatureSupported, new utility method in CompatibilityUtils, and related vdc_config entries (sql script) c) Changes in gluster related sources (like GlusterManager) to make use of GlusterFeatureSupported I don't really understand the value-add this brings in (I think the patch in it's current shape gives a better idea of what is being done), but will do it nevertheless to get things moving. -- To view, visit http://gerrit.ovirt.org/12970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
