Yair Zaslavsky has posted comments on this change.
Change subject: gluster: added cluster level check
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java
Line 7: /**
Line 8: * Convenience class to check if a gluster feature is supported or not
in any given version.<br>
Line 9: * Methods should be named by feature and accept version to check
against.
Line 10: */
Line 11: public class GlusterFeatureSupported {
Ok, so now that I understand what GlusterFwatureSupported is, why can't it
reuse inside FeatureSupported?
Line 12: /**
Line 13: * Checks if the given version is >= the minimum version
requirement for the feature
Line 14: *
Line 15: * @param featureSupportedFrom
--
To view, visit http://gerrit.ovirt.org/12970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
