Yair Zaslavsky has posted comments on this change.
Change subject: gluster: added cluster level check
......................................................................
Patch Set 6: (2 inline comments)
+ I agree with comments of Omer
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
Line 165: result = validateMetrics();
Line 166: }
Line 167:
Line 168: if (getVdsGroup().supportsGlusterService()
Line 169: &&
!GlusterFeatureSupported.gluster(getVdsGroup().getcompatibility_version())) {
Why not use the FeatureSupported infra?
Line 170:
addCanDoActionMessage(VdcBllMessages.GLUSTER_NOT_SUPPORTED);
Line 171:
addCanDoActionMessage(String.format("$compatibilityVersion %1$s",
getVdsGroup().getcompatibility_version().getValue()));
Line 172: result = false;
Line 173: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java
Line 7: /**
Line 8: * Convenience class to check if a gluster feature is supported or not
in any given version.<br>
Line 9: * Methods should be named by feature and accept version to check
against.
Line 10: */
Line 11: public class GlusterFeatureSupported {
Please use the already existing FeatureSupported.
IMHO, we should not have separate util for gluster.
Line 12: /**
Line 13: * Checks if the given version is >= the minimum version
requirement for the feature
Line 14: *
Line 15: * @param featureSupportedFrom
--
To view, visit http://gerrit.ovirt.org/12970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
