Eli Mesika has posted comments on this change.

Change subject: gluster: added cluster level check
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 480: -- Gluster refresh rates (in seconds)
Line 481: select fn_db_add_config_value('GlusterRefreshRateLight', '5', 
'general');
Line 482: select fn_db_add_config_value('GlusterRefreshRateHeavy', '300', 
'general');
Line 483: -- Gluster features supported versions
Line 484: select fn_db_add_config_value('GlusterSupportedFrom', '3.1', 
'general');
Can you please move this key to next row , so it will remain ordered?
Thanks
Line 485: select 
fn_db_add_config_value('GlusterRefreshHeavyWeightSupportedFrom', '3.2', 
'general');
Line 486: 
Line 487: select 
fn_db_add_config_value('LogMaxPhysicalMemoryUsedThresholdInPercentage', '95', 
'general');
Line 488: select fn_db_add_config_value('LogMaxCpuUsedThresholdInPercentage', 
'95', 'general');


--
To view, visit http://gerrit.ovirt.org/12970
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to