Alex Lourie has posted comments on this change. Change subject: packaging: configuring ovirt-engine on upgrade ......................................................................
Patch Set 2: (2 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 1655: basedefs.DB_NAME, Line 1656: ) Line 1657: Line 1658: # Update DB url with secured connection Line 1659: if os.path.exists(basedefs.OLD_ENGINE_SERVICE_XML): It means that we configure service to connect to DB without SSL Line 1660: xmlObj = XMLConfigFileHandler(basedefs.OLD_ENGINE_SERVICE_XML) Line 1661: xmlObj.open() Line 1662: xmlObj.registerNs( Line 1663: 'datasource', Line 1681: encryptedPassword = encryptEngineDBPass(password=dbPassword, Line 1682: maskList=masked_value_set) Line 1683: Line 1684: proxyEnabled = False Line 1685: # If proxy already enabled, update the value the value of proxyEnabled Line 1686: if os.path.exists(basedefs.FILE_OVIRT_HTTPD_CONF): Line 1687: proxyEnabled = True Line 1688: backup_file = "%s.%s_%s" % ( Line 1689: basedefs.FILE_OVIRT_HTTPD_CONF, -- To view, visit http://gerrit.ovirt.org/11825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf596fa9ecaae5ccc6580c19563b21f706d11cfc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches