Ofer Schreiber has posted comments on this change. Change subject: packaging: configuring ovirt-engine on upgrade ......................................................................
Patch Set 2: I would prefer that you didn't submit this (6 inline comments) "Core" code looks good. however, I'm missing the purpose of this patch. what was changed between 3.1 and 3.2? when? what the current status of upgrade? .................................................... Commit Message Line 6: Line 7: packaging: configuring ovirt-engine on upgrade Line 8: Line 9: * Added a function that configures ovirt-engine Line 10: service configuration on upgrade from 3.1 Configures what? what is the exact change your'e doing? why we need it? Line 11: Line 12: Change-Id: Idf596fa9ecaae5ccc6580c19563b21f706d11cfc Line 13: Bug-Url: https://bugzilla.redhat.com/906270 .................................................... File packaging/fedora/setup/common_utils.py Line 1655: basedefs.DB_NAME, Line 1656: ) Line 1657: Line 1658: # Update DB url with secured connection Line 1659: if os.path.exists(basedefs.OLD_ENGINE_SERVICE_XML): Do we really need this "if", what happens if it doesn't exists? Line 1660: xmlObj = XMLConfigFileHandler(basedefs.OLD_ENGINE_SERVICE_XML) Line 1661: xmlObj.open() Line 1662: xmlObj.registerNs( Line 1663: 'datasource', Line 1681: encryptedPassword = encryptEngineDBPass(password=dbPassword, Line 1682: maskList=masked_value_set) Line 1683: Line 1684: proxyEnabled = False Line 1685: # If proxy already enabled, update the value new line before comment. updates which value? Line 1686: if os.path.exists(basedefs.FILE_OVIRT_HTTPD_CONF): Line 1687: proxyEnabled = True Line 1688: backup_file = "%s.%s_%s" % ( Line 1689: basedefs.FILE_OVIRT_HTTPD_CONF, .................................................... File packaging/fedora/setup/engine-setup.py Line 742: logging.error(traceback.format_exc()) Line 743: raise Exception(output_messages.ERR_EXP_UPD_HTTPD_SSL_CONFIG%(basedefs.FILE_HTTPD_SSL_CONFIG)) Line 744: Line 745: Line 746: def _redirectUrl(): Why should we keep it? Line 747: utils.redirectUrl() Line 748: Line 749: Line 750: def _configureHttpdPort(): .................................................... File packaging/fedora/setup/post_upgrade.py Line 10: import traceback Line 11: Line 12: Line 13: MSG_ERR_UPDATE_PRODUCT_VERSION="Error updating product version" Line 14: ? Line 15: Line 16: def updateProductVersion(): Line 17: """ Line 18: Update product version in vdc options Line 25: except: Line 26: logging.error(traceback.format_exc()) Line 27: logging.error(MSG_ERR_UPDATE_PRODUCT_VERSION) Line 28: Line 29: ? Line 30: def run(): Line 31: # Update product version in db from rpm version -- To view, visit http://gerrit.ovirt.org/11825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf596fa9ecaae5ccc6580c19563b21f706d11cfc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
