Juan Hernandez has posted comments on this change.
Change subject: packaging: configuring ovirt-engine on upgrade
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/post_upgrade.py
Line 33: masked_value_set = [dbPassword]
Line 34: encryptedPassword = utils.encryptEngineDBPass(password=dbPassword,
Line 35:
maskList=masked_value_set)
Line 36:
Line 37: # Edit sysconfig file
I think we need to do this conditionally, as in 3.1 the user could have
selected to configure Apache as a proxy. I mean, we can't set
proxyEnabled=False in all situations.
In order to check if the proxy should be enabled we will need to check if the
file /etc/httpd/conf.d/ovirt-engine.conf exists. In 3.1 we created it with the
following content:
ProxyPass / ajp://localhost:8009
In 3.2 we generate it from the template in
packaging/fedora/setup/ovirt-engine-proxy.conf.in.
If it does exist (and assuming that the user didn't modify it manually) we need
to do something like this:
utils.editEngineSysconfig(
proxyEnabled=True,
...
)
Also, when the proxy is enabled, we will need to change the AJP port. In 3.1
the default was 8009, in 3.2 it is 8702, so either we regenerate the
/etc/httpd/conf.d/ovirt-engine.conf file from the template (making a backup,
and probably warning the user) to use the new port or we add the old port to
/etc/sysconfig/ovirt-engine:
ENGINE_AJP_PORT=8009
Line 38: utils.editEngineSysconfig(proxyEnabled=False,
Line 39: dbUrl=dbUrl,
Line 40: dbUser=utils.getDbUser(),
Line 41: fqdn=fqdn,
--
To view, visit http://gerrit.ovirt.org/11825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf596fa9ecaae5ccc6580c19563b21f706d11cfc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
