Andrey Gordeev has posted comments on this change.

Change subject: packaging: configuring ovirt-engine on upgrade
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File packaging/fedora/setup/common_utils.py
Line 1673:             # Means ssl mode was set
Line 1674:             dbUrl = dbUrl + 
"?ssl=true&sslfactory=org.postgresql.ssl.NonValidatingFactory"
Line 1675: 
Line 1676:     # Get current configuration
Line 1677:     fqdn, httpPort, httpsPort = getHostParams(basedefs.FILE_WEB_CONF)
Will not work if web-conf.js file will be moved to web-conf.js.rpmsave
Line 1678: 
Line 1679:     # Get encrypted password
Line 1680:     masked_value_set = [dbPassword]
Line 1681:     encryptedPassword = encryptEngineDBPass(password=dbPassword,


--
To view, visit http://gerrit.ovirt.org/11825
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf596fa9ecaae5ccc6580c19563b21f706d11cfc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Andrey Gordeev <dre...@gmail.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to