Andrey Gordeev has posted comments on this change. Change subject: packaging: configuring ovirt-engine on upgrade ......................................................................
Patch Set 4: (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 981: else: Line 982: logging.info("Info: %s file found. Continue.", basedefs.DB_PASS_FILE) Line 983: Line 984: Line 985: startVersion = utils.getEngineVersion() This will not work if file with version number is absent Line 986: Line 987: # Functions/parameters definitions Line 988: currentDbName = basedefs.DB_NAME Line 989: stopEngineService = [stopEngine] -- To view, visit http://gerrit.ovirt.org/11825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf596fa9ecaae5ccc6580c19563b21f706d11cfc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Andrey Gordeev <dre...@gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches