Liron Aravot has posted comments on this change.
Change subject: core: improve logging
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
Line 29: _managersDictionary.clear();
Line 30: for (Version ver : Config.<HashSet<Version>>
GetValue(ConfigValues.SupportedClusterLevels)) {
Line 31: _managersDictionary.put(ver, new CpuFlagsManager(ver));
Line 32: }
Line 33: log.info("Finished initializing dictionaries" +
CpuFlagsManagerHandler.class.getSimpleName());
why "+ CpuFlagsManagerHandler.class.getSimpleName() "?
if you do leave it..space is missing between "dictionaries" and it.
Line 34: }
Line 35:
Line 36: public static String GetVDSVerbDataByCpuName(String name, Version
ver) {
Line 37: final CpuFlagsManager cpuFlagsManager =
_managersDictionary.get(ver);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
Line 1: package org.ovirt.engine.core.bll.network;
Line 2:
Line 3: import java.util.*;
please use FQCN for imports.
Line 4: import java.util.concurrent.locks.ReentrantReadWriteLock;
Line 5:
Line 6: import org.apache.commons.lang.StringUtils;
Line 7: import org.ovirt.engine.core.common.AuditLogType;
--
To view, visit http://gerrit.ovirt.org/10823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
