Liron Aravot has posted comments on this change.
Change subject: core: improve logging
......................................................................
Patch Set 3: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
Line 24: private static Map<Version, CpuFlagsManager> _managersDictionary =
Line 25: new HashMap<Version, CpuFlagsManager>();
Line 26:
Line 27: public static void InitDictionaries() {
Line 28: log.info("Start initializing " +
CpuFlagsManagerHandler.class.getSimpleName());
we init here the directories.. i'd suggest to change the logging.
Line 29: _managersDictionary.clear();
Line 30: for (Version ver : Config.<HashSet<Version>>
GetValue(ConfigValues.SupportedClusterLevels)) {
Line 31: _managersDictionary.put(ver, new CpuFlagsManager(ver));
Line 32: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
Line 57: try {
Line 58: log.info("Init VM Custom Properties utilities");
Line 59: VmPropertiesUtils.getInstance().init();
Line 60: } catch (InitializationException e) {
Line 61: log.error("Initialization failed",e);
maybe change this log as well?
Line 62: throw new RuntimeException(e);
Line 63: }
Line 64: }
Line 65:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 72: /**
Line 73: * private constructor to initialize the quartz scheduler
Line 74: */
Line 75: private IsoDomainListSyncronizer() {
Line 76: log.info("Start initializing " +
this.getClass().getSimpleName());
I'd change here to IsoDomainListSyncronizer
Line 77: repoStorageDom =
DbFacade.getInstance().getRepoFileMetaDataDao();
Line 78: isoDomainRefreshRate = Config.<Integer>
GetValue(ConfigValues.AutoRepoDomainRefreshTime) * MIN_TO_MILLISECONDS;
Line 79:
SchedulerUtilQuartzImpl.getInstance().scheduleAFixedDelayJob(this,
Line 80: "fetchIsoDomains",
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java
Line 28: /**
Line 29: * Initializes the Job Cleanup scheduler
Line 30: */
Line 31: public void initialize() {
Line 32: log.info("Start initializing " +
this.getClass().getSimpleName());
I'd change to JobRepositoryCleanupManager
Line 33: succeededJobTime = Config.<Integer>
GetValue(ConfigValues.SucceededJobCleanupTimeInMinutes).intValue();
Line 34: failedJobTime = Config.<Integer>
GetValue(ConfigValues.FailedJobCleanupTimeInMinutes).intValue();
Line 35:
Line 36: Integer cleanupFrequency = Config.<Integer>
GetValue(ConfigValues.JobCleanupRateInMinutes);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
Line 49: * In memory tree initialized during initialization
Line 50: */
Line 51:
Line 52: protected void init() {
Line 53: log.info("Start initializing " +
this.getClass().getSimpleName());
I'd cahnge to TagsDirector
Line 54: tagsMapByID.clear();
Line 55: tagsMapByName.clear();
Line 56: tags root = new tags("root", null, true, ROOT_TAG_ID, "root");
Line 57: AddTagToHash(root);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancer.java
Line 48: }
Line 49: }
Line 50:
Line 51: public static void EnableLoadBalancer() {
Line 52: log.info("Start scheduling to enable load balancer");
perhaps vds load blanacer
Line 53:
SchedulerUtilQuartzImpl.getInstance().scheduleAFixedDelayJob(instance,
"PerformLoadBalancing", new Class[] {},
Line 54: new Object[] {}, Config.<Integer>
GetValue(ConfigValues.VdsLoadBalancingeIntervalInMinutes),
Line 55: Config.<Integer>
GetValue(ConfigValues.VdsLoadBalancingeIntervalInMinutes), TimeUnit.MINUTES);
Line 56: log.info("Finished scheduling to enable load balancer");
--
To view, visit http://gerrit.ovirt.org/10823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
