Alissa Bonas has posted comments on this change.
Change subject: core: improve logging
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
Line 22: return _instance;
Line 23: }
Line 24:
Line 25: private AuditLogCleanupManager() {
Line 26: log.info("Start initializing " +
this.getClass().getSimpleName());
you're right regarding class name itself. However in many places there are
several different things initialized in same class (like for example in class
Backend itself which I also modified in this patch), thus I do think it's nice
to mention WHAT exactly is initialized. So I wrote it in a more human readable
way instead of just class name.
I hope you're OK with it :)
Line 27: Calendar calendar = new GregorianCalendar();
Line 28: Date mAuditLogCleanupTime = Config.<DateTime>
GetValue(ConfigValues.AuditLogCleanupTime);
Line 29: calendar.setTimeInMillis(mAuditLogCleanupTime.getTime());
Line 30:
--
To view, visit http://gerrit.ovirt.org/10823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
