Liron Aravot has posted comments on this change.
Change subject: core: improve logging
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
Line 57: try {
Line 58: log.info("Init VM Custom Properties utilities");
Line 59: VmPropertiesUtils.getInstance().init();
Line 60: } catch (InitializationException e) {
Line 61: log.error("Initialization failed",e);
Initialization of vm cust...failed
Line 62: throw new RuntimeException(e);
Line 63: }
Line 64: }
Line 65:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 72: /**
Line 73: * private constructor to initialize the quartz scheduler
Line 74: */
Line 75: private IsoDomainListSyncronizer() {
Line 76: log.info("Start initializing " +
this.getClass().getSimpleName());
Of course, but here
http://gerrit.ovirt.org/#/c/10823/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
you wrote it explictly rather then using .getSimpleName() - i'd change to keep
uniformity..here or there.
Line 77: repoStorageDom =
DbFacade.getInstance().getRepoFileMetaDataDao();
Line 78: isoDomainRefreshRate = Config.<Integer>
GetValue(ConfigValues.AutoRepoDomainRefreshTime) * MIN_TO_MILLISECONDS;
Line 79:
SchedulerUtilQuartzImpl.getInstance().scheduleAFixedDelayJob(this,
Line 80: "fetchIsoDomains",
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
Line 49: * In memory tree initialized during initialization
Line 50: */
Line 51:
Line 52: protected void init() {
Line 53: log.info("Start initializing " +
this.getClass().getSimpleName());
Of course, but here
http://gerrit.ovirt.org/#/c/10823/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java
you wrote it explictly rather then using .getSimpleName() - i'd change to keep
uniformity..here or there.
Line 54: tagsMapByID.clear();
Line 55: tagsMapByName.clear();
Line 56: tags root = new tags("root", null, true, ROOT_TAG_ID, "root");
Line 57: AddTagToHash(root);
--
To view, visit http://gerrit.ovirt.org/10823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
