Shireesh Anjal has posted comments on this change.
Change subject: engine: gluster action version check added
......................................................................
Patch Set 4: (1 inline comment)
Response to Roy's question in-line.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 47: @Override
Line 48: protected boolean isBackwardsCompatible() {
Line 49: setClusterId();
Line 50: return super.isBackwardsCompatible();
Line 51: }
If the DAO is invoked from the constructor, there is no way to set the mock dao
inside the object, as the object itself is not created yet. If you think it is
possible to mock the DAO when it is being invoked from the constructor of a
command, can you please give me a reference, or sample code?
Line 52:
Line 53: @Override
Line 54: protected boolean canDoAction() {
Line 55: if (getGlusterVolume() == null) {
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
