Shireesh Anjal has posted comments on this change. Change subject: engine: gluster action version check added ......................................................................
Patch Set 4: I believe the concern is coming from the fact that isBackwardsCompatible() is being overridden to initialize a variable. The primary reason behind that is that this initialization cannot be done in the constructor, as it involves a DB operation, and will require static mocking in test case, which, I believe should not be used any more. If we really want to avoid overriding of isBackwardsCompatible() for this purpose, the right way, IMO, will be for CommandBase to provide a standard way of initializing such variables. How about a new method, say init() or initVars() in CommandBase, that gets called after the constructor, and before isBackwardsCompatible(). This will allow sub-classes to override this new method for such initializations, and will make it possible to use regular mocking in the test cases. -- To view, visit http://gerrit.ovirt.org/9670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
