Shireesh Anjal has posted comments on this change.
Change subject: engine: gluster action version check added
......................................................................
Patch Set 4: (1 inline comment)
Answer to Omer's comment in-line.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 47: @Override
Line 48: protected boolean isBackwardsCompatible() {
Line 49: setClusterId();
Line 50: return super.isBackwardsCompatible();
Line 51: }
No Omer, the very reason that we had moved it to canDoAction was that the DAO
cannot be mocked if being called in the constructor. Refer patch
http://gerrit.ovirt.org/6365
I believe you won't see something like this in regular bll commands, because
the vds group id comes from the parameters object, and is directly set in the
constructor - no db operations involved.
In our case though, what we get in the parameters object is the volume id. We
then fetch the volume object from db, extract the vds group id from it, and
then set it. Hence a db operation is involved.
Line 52:
Line 53: @Override
Line 54: protected boolean canDoAction() {
Line 55: if (getGlusterVolume() == null) {
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
