Shireesh Anjal has posted comments on this change.
Change subject: engine: gluster action version check added
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1540_add_gluster_action_version_map.sql
Line 1: insert into action_version_map (action_type, cluster_minimal_version,
storage_pool_minimal_version)
It might be a good idea to add a comment containing the action name before
every insert, as the numbers (1400, 1401, etc) are not easy to remember.
Line 2: select 1400, '3.1', '*'
Line 3: where not exists (select 1 from action_version_map where
action_type = 1400);
Line 4:
Line 5: insert into action_version_map (action_type, cluster_minimal_version,
storage_pool_minimal_version)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 39: }
Line 40: }
Line 41:
Line 42: @Override
Line 43: public VdcReturnValueBase canDoActionOnly() {
canDoActionOnly() is called only from MultipleActionsRunner. So, will this work
for those gluster actions that are executed directly, e.g. create volume ?
Line 44: setClusterId();
Line 45: return super.canDoActionOnly();
Line 46: }
Line 47:
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommandTest.java
Line 13: import org.ovirt.engine.core.common.businessentities.VDS;
Line 14: import org.ovirt.engine.core.common.businessentities.VDSStatus;
Line 15: import
org.ovirt.engine.core.common.businessentities.gluster.AccessProtocol;
Line 16: import
org.ovirt.engine.core.common.businessentities.gluster.GlusterStatus;
Line 17: import
org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeEntity;
Nothing changed except position of the import. So this source can be removed
from the patch.
Line 18: import
org.ovirt.engine.core.common.businessentities.gluster.GlusterVolumeType;
Line 19: import
org.ovirt.engine.core.common.businessentities.gluster.TransportType;
Line 20: import org.ovirt.engine.core.compat.Guid;
Line 21: import org.ovirt.engine.core.dao.gluster.GlusterVolumeDao;
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
