Selvasundaram has posted comments on this change.

Change subject: engine: gluster action version check added
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File 
backend/manager/dbscripts/upgrade/03_02_0090_add_gluster_action_version_map.sql
Line 1: -- Create gluster volume
Line 2: insert into action_version_map (action_type, cluster_minimal_version, 
storage_pool_minimal_version)
Line 3:     select 1400, '3.1', '*'
Line 4:         where not exists (select 1 from action_version_map where 
action_type = 1400);
Done
Line 5: 
Line 6: -- Set gluster volume option
Line 7: insert into action_version_map (action_type, cluster_minimal_version, 
storage_pool_minimal_version)
Line 8:     select 1401, '3.1', '*'


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 41:     }
Line 42: 
Line 43:     @Override
Line 44:     protected boolean isBackwardsCompatible() {
Line 45:         setClusterId();
Done
Line 46:         return super.isBackwardsCompatible();
Line 47:     }
Line 48: 
Line 49:     @Override


--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12047a40a4ef81901ce3050f1d39abe0af746d55
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to