Yair Zaslavsky has posted comments on this change.

Change subject: engine: Introducing a queue for failovers event
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 155:                                         storagePoolId);
Line 156:                                 lock.lock();
Line 157:                                 try {
Line 158:                                     for (Pair<Event, 
FutureTask<EventResult>> task : poolsEventsMap.get(storagePoolId)) {
Line 159:                                         log.infoFormat("The following 
task {0} was cancelled, because of recosntruct was run before",
Maybe in order not to mislead with vdsm task, call it with some other name?
Line 160:                                                 task.getFirst());
Line 161:                                         task.getSecond().cancel(true);
Line 162:                                     }
Line 163:                                     
poolCurrentEventMap.remove(storagePoolId);


--
To view, visit http://gerrit.ovirt.org/9838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1224feacdcdaaaf0b59d26105805ba7ef2a2fff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to