Michael Kublin has posted comments on this change.
Change subject: engine: Introducing a queue for failovers event
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 34: public class EventQueueMonitor implements EventQueue {
Line 35:
Line 36: private static Log log =
LogFactory.getLog(EventQueueMonitor.class);
Line 37:
Line 38: private static final ConcurrentMap<Guid, ReentrantLock>
poolsLockMap = new ConcurrentHashMap<Guid, ReentrantLock>();
Actually it is not matter here . I can give to container managed a beans, but I
can switch to @Singleton
Line 39: private static final Map<Guid, Queue<Pair<Event,
FutureTask<EventResult>>>> poolsEventsMap =
Line 40: new HashMap<Guid, Queue<Pair<Event,
FutureTask<EventResult>>>>();
Line 41: private static final Map<Guid, Event> poolCurrentEventMap = new
HashMap<Guid, Event>();
Line 42:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java
Line 1: package org.ovirt.engine.core.common.eventqueue;
AsyncTask also in common, so if we have a policy that everything that is in
common should be exposed to gui, I will move it, but at any case it minor
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class Event {
--
To view, visit http://gerrit.ovirt.org/9838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1224feacdcdaaaf0b59d26105805ba7ef2a2fff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
