Michael Kublin has posted comments on this change. Change subject: Reinitialize DC doesn't connect all hosts to the new master(#880180) ......................................................................
Patch Set 2: Liron, so lets think: Reconstruct flow: Go throught all vds refresh and on case of some exception connect. Recovery flow: Go through all vds connect and after that refresh, no need for exception handling on case of exception at refresh. especially additional refresh. No need for additional method that u introduced. Where it is 99% percent common. You already introduced a method that at some flow should return only true and complicated a very simple code. "right now there is no need to copy the method in my opinion - 99%" - your change at connectAndRefreshAllUpHosts in order to solve bug at reconstruct flow caused to regression in recovery flow. I don't think that these means 99% common. -- To view, visit http://gerrit.ovirt.org/9748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3733b732b37f3a687b24f90bfdb1799757434d75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
