Allon Mureinik has posted comments on this change.
Change subject: perform connectStorageServer to hosts after during
reconstruct/recovery(#880180)
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 200: /**
Line 201: * performs any connect related operations if needed before
attempting
Line 202: * to connect/refresh pool information.
Line 203: * @param vds
Line 204: * @return
Either document or remove @param and @return
Line 205: */
Line 206: private boolean connectVdsToNewMaster(VDS vds) {
Line 207: storage_domains masterDomain = getNewMaster(false);
Line 208: if (vds.getId().equals(getVds().getId())
Line 209: ||
StorageHelperDirector.getInstance().getItem(masterDomain.getstorage_type())
Line 210: .ConnectStorageToDomainByVdsId(masterDomain,
vds.getId())) {
Line 211: return true;
Line 212: }
Line 213: log.errorFormat("Error while trying connect host {0} to the
needed storage server during the reinitialization of Data Center {1}",
The terminology in this class is storage pool, not data center - please fix the
log.
Line 214: vds.getId(),
Line 215: getStoragePool().getId());
Line 216: return false;
Line 217: }
Line 213: log.errorFormat("Error while trying connect host {0} to the
needed storage server during the reinitialization of Data Center {1}",
Line 214: vds.getId(),
Line 215: getStoragePool().getId());
Line 216: return false;
Line 217: }
Consider the following flow, maybe it'll be more readable (excuse the
psuedocode)
if (getVds() == vds)
return true;
boolean connenctRetVal = connectStorageServer()
if (!connenctRetVal) {
log.error ("oh no!")
}
return connenctRetVal;
Line 218:
Line 219: private void connectAndRefreshAllUpHosts(final boolean
commandSucceeded) {
Line 220: for (VDS vds : getAllRunningVdssInPool()) {
Line 221: try {
--
To view, visit http://gerrit.ovirt.org/9748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3733b732b37f3a687b24f90bfdb1799757434d75
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
