Sandro Bonazzola has posted comments on this change. Change subject: Convert OVF to VDSM create parameters (vm.conf) ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42342/1/src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py File src/ovirt_hosted_engine_setup/ovf/ovf2vmConf.py: Line 29: tmpdir, Line 30: ovfPath, Line 31: ) Line 32: ) Line 33: vmConf = {} > indeed, I'm working with that. no it won't. on rhel it's currently rhel-6.5.0 and on fedora it's pc. using pc may lead to have 2 different emulated machines if one host is running rhel7.1 and the other one is running rhel7.2. Line 34: # general Line 35: vmConf['vmId'] = tree.find('Content/Section').attrib[OVF_NS + 'id'] Line 36: vmConf['vmName'] = tree.find('Content/Name').text Line 37: vmConf['display'] = DISPLAY_TYPES.get( -- To view, visit https://gerrit.ovirt.org/42342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7dd763dd701158e945ed2006520c6a073318d2c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
