Eli Mesika has posted comments on this change. Change subject: core[DB]: Adding external status to DB ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42132/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 8: storage_domain_static.storage AS storage, Line 9: storage_domain_static.storage_name AS storage_name, Line 10: storage_domain_static.storage_description AS storage_description, Line 11: storage_domain_static.storage_comment AS storage_comment, Line 12: storage_pool_iso_map.storage_pool_id AS storage_pool_id, > You'd probably want the external status here too? No, it is not a static information AFAIK , why should this be added to a static entity (for example in VDS external status was not adde ro vds_static...) Line 13: storage_pool_iso_map.status AS status, Line 14: storage_domain_static.storage_domain_type AS storage_domain_type, Line 15: storage_domain_static.storage_type AS storage_type, Line 16: storage_domain_static.storage_domain_format_type AS storage_domain_format_type, -- To view, visit https://gerrit.ovirt.org/42132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdfc25b91eacfa73be783b3b84827e0d5788b91d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
