Oved Ourfali has posted comments on this change.

Change subject: core[DB]: Adding external status to DB
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42132/1/packaging/dbscripts/create_views.sql
File packaging/dbscripts/create_views.sql:

Line 566: FROM
Line 567:     storage_domain_static
Line 568: INNER JOIN storage_domain_dynamic ON storage_domain_static.id = 
storage_domain_dynamic.id
Line 569: INNER JOIN storage_pool_iso_map ON storage_domain_static.id = 
storage_pool_iso_map.storage_id
Line 570: INNER JOIN storage_pool ON storage_pool_iso_map.storage_pool_id = 
storage_pool.id
> You won't, just like you don't get status.
btw, no duplicated there according to Eli, due to the second join.
Line 571: 
Line 572: LEFT
Line 573: OUTER JOIN (
Line 574:         SELECT


-- 
To view, visit https://gerrit.ovirt.org/42132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdfc25b91eacfa73be783b3b84827e0d5788b91d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to