Ondra Machacek has posted comments on this change. Change subject: tools: extensions-tool: initial implementation aaa ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java: Line 586: for (String f : (List<String>)actionArgs.get("flags")) { Line 587: if(f.equals("resolve-groups")) { Line 588: flags += 1; Line 589: } else if (f.equals("resolve-groups-recursive")) { Line 590: flags += 2; > why do you hard code the flags? I can't think of solution how I can efectivelly map values from command line args to flags of Authz.InvokeKeys.QUERY_FLAGS. Line 591: } Line 592: } Line 593: } Line 594: return flags; https://gerrit.ovirt.org/#/c/41605/3/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties: Line 31: Line 32: authn-authenticate_credentials.arg.extension-name.name = extension-name Line 33: authn-authenticate_credentials.arg.extension-name.mandatory = true Line 34: authn-authenticate_credentials.arg.extension-name.type = has_argument Line 35: authn-authenticate_credentials.arg.extension-name.help = Name of authn extension. > why do you need extension-name? In first patch set you suggest to let user specify the authz. And we also need authn, to authenticate first, no ? Line 36: Line 37: authn-authenticate_credentials.arg.user-name.name = user-name Line 38: authn-authenticate_credentials.arg.user-name.mandatory = true Line 39: authn-authenticate_credentials.arg.user-name.type = has_argument Line 91: login-user.arg.help.value = true Line 92: login-user.arg.help.default = false Line 93: Line 94: login-user.arg.flags.name = flags Line 95: login-user.arg.flags.help = Flags to be used for search > missing valid values, missing metavar Valid values? valid values are: resolve-groups-recursive|resolve-groups It's specified in *.flags.matcher Line 96: login-user.arg.flags.multivalue = true Line 97: login-user.arg.flags.matcher = resolve-groups-recursive|resolve-groups Line 98: Line 99: login-user.help.header = Login action of aaa interface test module -- To view, visit https://gerrit.ovirt.org/41605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1811c5845bf02c30f1acd2938074070fb661af38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
