Juan Hernandez has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File ovirt-guest-agent.spec
Line 9: Release: %{release_version}%{?dist}
Line 10: Summary: The oVirt Guest Agent
Line 11: Group: Applications/System
Line 12: License: GPLv2+
Line 13: URL: http://gerrit.ovirt.org/p/ovirt-guest-agent.git
I would suggest to put here an URL that is more informative for users, maybe
the following wiki page:
http://wiki.ovirt.org/wiki/Category:Ovirt_guest_agent
That page may need to be updated as well.
Line 14: Source0: http://ghammer.fedorapeople.org/%{name}-%{version}.tar.bz2
Line 15: BuildRequires: libtool
Line 16: BuildRequires: pam-devel
Line 17: BuildRequires: python2-devel
Line 10: Summary: The oVirt Guest Agent
Line 11: Group: Applications/System
Line 12: License: GPLv2+
Line 13: URL: http://gerrit.ovirt.org/p/ovirt-guest-agent.git
Line 14: Source0: http://ghammer.fedorapeople.org/%{name}-%{version}.tar.bz2
I this the official conduit for distribution of stable releases? There is no
index page there, so it is a bit difficult to find new releases.
You may want to consider giving instead the instructions to checkout the code,
something like this:
# git clone git://gerrit.ovirt.org/ovirt-guest-agent.git
# cd ovirt-guest-agent
# git archive --prefix=ovirt-guest-agent-1.0.5
--output=ovirt-guest-agent-1.0.5.tar.bz2
35c77e08698879a43ced2251a562feacd8168d60
That is not very easy either, because there are no tags in the git repository.
I suggest to add them.
Line 15: BuildRequires: libtool
Line 16: BuildRequires: pam-devel
Line 17: BuildRequires: python2-devel
Line 18: %if 0%{?fedora} >= 18
--
To view, visit http://gerrit.ovirt.org/8715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
