Alon Bar-Lev has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File Makefile.am
Line 14: Makefile.in
Line 15:
Line 16: install-exec-hook:
Line 17: $(MKDIR_P) $(DESTDIR)/$(datadir)/ovirt-guest-agent
Line 18: $(LN_S) /usr/bin/consolehelper
$(DESTDIR)/$(datadir)/ovirt-guest-agent/ovirt-locksession
$(bindir) :)
$(pkgdatadir)?
Line 19: $(LN_S) /usr/bin/consolehelper
$(DESTDIR)/$(datadir)/ovirt-guest-agent/ovirt-shutdown
....................................................
File ovirt-guest-agent.spec
Line 29: Requires: python-ethtool >= 0.4-1
Line 30: Requires: udev >= 095-14.23
Line 31: Requires: kernel > 2.6.18-238.5.0
Line 32: Requires: usermode
Line 33: Provides: %{name} = %{version}-%{release}
Is that required?
Line 34:
Line 35: %if 0%{?fc16}
Line 36: Conflicts: selinux-policy < 3.10.0-77
Line 37: %endif
Line 40: %endif
Line 41:
Line 42: %package pam-module
Line 43: Summary: PAM module for the oVirt Guest Agent
Line 44: ExclusiveArch: i686 x86_64
Why do we want to limit?
Line 45: Requires: %{name} = %{version}-%{release}
Line 46: Requires: pam
Line 47:
Line 48: %package gdm-plugin
Line 108: install -Dm 0644 ovirt-guest-agent/ovirt-guest-agent.service
%{buildroot}%{_unitdir}/ovirt-guest-agent.service
Line 109:
Line 110: # Update timestamps on Python files in order to avoid differences
between
Line 111: # .pyc/.pyo files.
Line 112: touch -r %{SOURCE0} %{buildroot}%{_datadir}/ovirt-guest-agent/*.py
Still need to know why we need this.
This is totally wrong. We need to install the *.py*
Modify agent_DATA= to agent_PYTHON= at Makefile.am, then autoreconf -ivf.
Now the make install will produce up to date pyc which should be installed by
the spec.
Also, please submit a pre-path for dos2unix of all files... :)
Thanks!
Line 113:
Line 114: install -d %{buildroot}%{_localstatedir}/log/ovirt-guest-agent
Line 115: install -d %{buildroot}%{_localstatedir}/lock/subsys/ovirt-guest-agent
Line 116:
--
To view, visit http://gerrit.ovirt.org/8715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
