Vinzenz Feenstra has posted comments on this change. Change subject: Updated spec file to follow packaging guide lines (BZ#772608) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File ovirt-guest-agent.spec Line 108: install -Dm 0644 ovirt-guest-agent/ovirt-guest-agent.service %{buildroot}%{_unitdir}/ovirt-guest-agent.service Line 109: Line 110: # Update timestamps on Python files in order to avoid differences between Line 111: # .pyc/.pyo files. Line 112: touch -r %{SOURCE0} %{buildroot}%{_datadir}/ovirt-guest-agent/*.py Ok Line 113: Line 114: mkdir -p %{buildroot}%{_localstatedir}/log/ovirt-guest-agent Line 115: mkdir -p %{buildroot}%{_localstatedir}/lock/subsys/ovirt-guest-agent Line 116: -- To view, visit http://gerrit.ovirt.org/8715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Gal Hammer <gham...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches