Vinzenz Feenstra has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File ovirt-guest-agent.spec
Line 29: Requires: python-ethtool >= 0.4-1
Line 30: Requires: udev >= 095-14.23
Line 31: Requires: kernel > 2.6.18-238.5.0
Line 32: Requires: usermode
Line 33: Provides: %{name} = %{version}-%{release}
The complexity was needed to introduce to keep the ExclusiveArch instructions.
If I can get rid of them, as we talked about below, I can remove it.
The noarch-subpackage was a solution to avoid duplicating these items for every
architecture.
Before I did this change there was the mainpackage for each architecture, I
simply wanted to avoid duplicated content packages.
Line 34:
Line 35: %if 0%{?fc16}
Line 36: Conflicts: selinux-policy < 3.10.0-77
Line 37: %endif
Line 40: %endif
Line 41:
Line 42: %package pam-module
Line 43: Summary: PAM module for the oVirt Guest Agent
Line 44: ExclusiveArch: i686 x86_64
If you check how it was before, you will notice that this was there before,
just on the main package. If it is on the main package it is reflected on the
subpackages as well, as this is a RPM build time restriction.
However, I would prefer to remove it as well, it is not like that I am a big
fan of this :-). I just tried to keep the original intent as much as possible.
Line 45: Requires: %{name} = %{version}-%{release}
Line 46: Requires: pam
Line 47:
Line 48: %package gdm-plugin
Line 108: install -Dm 0644 ovirt-guest-agent/ovirt-guest-agent.service
%{buildroot}%{_unitdir}/ovirt-guest-agent.service
Line 109:
Line 110: # Update timestamps on Python files in order to avoid differences
between
Line 111: # .pyc/.pyo files.
Line 112: touch -r %{SOURCE0} %{buildroot}%{_datadir}/ovirt-guest-agent/*.py
I see, I did not notice so far. Good to know, I will do that.
Line 113:
Line 114: install -d %{buildroot}%{_localstatedir}/log/ovirt-guest-agent
Line 115: install -d %{buildroot}%{_localstatedir}/lock/subsys/ovirt-guest-agent
Line 116:
--
To view, visit http://gerrit.ovirt.org/8715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
