Vinzenz Feenstra has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File ovirt-guest-agent.spec
Line 1:
Line 2: %global release_version 2
Line 3:
Line 4: %global _moduledir /%{_lib}/security
Line 5: %global _kdmrc /etc/kde/kdm/kdmrc
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25global_preferred_over_.25define
Line 6:
Line 7: Name: ovirt-guest-agent
Line 8: Version: 1.0.5
Line 9: Release: %{release_version}%{?dist}
Line 6:
Line 7: Name: ovirt-guest-agent
Line 8: Version: 1.0.5
Line 9: Release: %{release_version}%{?dist}
Line 10: Summary: The oVirt Guest Agent
No it won't change the package name. The package name is based on "Name:" not
on the summary.
Line 11: Group: Applications/System
Line 12: License: GPLv2+
Line 13: URL: http://gerrit.ovirt.org/p/ovirt-guest-agent.git
Line 14: Source0: http://ghammer.fedorapeople.org/%{name}-%{version}.tar.bz2
Line 69: run-time data from within the guest itself. The agent also accepts
Line 70: control commands to be run executed within the OS (like: shutdown and
Line 71: restart).
Line 72:
Line 73: %description service
I will verify this.
Line 74: This is the oVirt management agent running inside the guest. The agent
Line 75: interfaces with the oVirt manager, supplying heart-beat info as well as
Line 76: run-time data from within the guest itself. The agent also accepts
Line 77: control commands to be run executed within the OS (like: shutdown and
--
To view, visit http://gerrit.ovirt.org/8715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
