Eli Mesika has posted comments on this change.

Change subject: core: adding engine Maintenance and Prepare mode.(#868639)
......................................................................


Patch Set 7: (2 inline comments)

....................................................
Commit Message
Line 9: Adding support for engine Maintenance mode that is controlled by a new
Line 10: configuration key named EngineMode (String).
Line 11: 
Line 12: Adding support for engine Prepare mode that is controlled by a new
Line 13: configuration value named Prepare.
This is not true any more please remove
Line 14: 
Line 15: The default value of those configuration keys is false, however, this
Line 16: value can be set to true in order to prevent new commands from being
Line 17: processed by the backend class.


Line 13: configuration value named Prepare.
Line 14: 
Line 15: The default value of those configuration keys is false, however, this
Line 16: value can be set to true in order to prevent new commands from being
Line 17: processed by the backend class.
Same , please update that this is a string with the possible value
Line 18: 
Line 19: MaintainceMode will prevent of running all commands and some queries 
marked by
Line 20: @DisableInMaintenanceMode annotation.
Line 21: 


--
To view, visit http://gerrit.ovirt.org/8669
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912dcb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to