Yair Zaslavsky has posted comments on this change.
Change subject: core: adding engine Maintenance mode
......................................................................
Patch Set 1: (1 inline comment)
Inline comment with some thought about different values for the config option
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 115: --Handling Enables Host Load Balancing system.
Line 116: select
fn_db_add_config_value('EnableVdsLoadBalancing','true','general');
Line 117: select
fn_db_add_config_value('ENGINEEARLib','%JBOSS_HOME%/server/engine-slimmed/deploy/engine.ear','general');
Line 118: --Handling Engine maintenance mode
Line 119: select
fn_db_add_config_value('EngineMaintenanceMode','false','general');
I wonder whether we would like to have "EngineMode" or "EngineExecutionMode"
instead.
I really hope that in the future, we won't have anything besides "OK" and
"Mainteinance" - but who knows :)
Line 120: --Handling Mail User Domain
Line 121: select fn_db_add_config_value('ENMailDomain','','general');
Line 122: --Handling Use HTML in message body
Line 123: select fn_db_add_config_value('ENMailIsBodyHtml','true','general');
--
To view, visit http://gerrit.ovirt.org/8669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912dcb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
