Barak Azulay has posted comments on this change.
Change subject: core: adding engine Maintenance and Prepare mode.(#868639)
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 293: public VdcReturnValueBase RunAction(VdcActionType actionType,
VdcActionParametersBase parameters) {
Line 294: VdcReturnValueBase returnValue =
isModeAllowToRunAction(actionType);
Line 295: if (returnValue != null) {
Line 296: return returnValue;
Line 297: }
According to the above condition, the logic is opposite from the bool value
Line 298: return runActionImpl(actionType, parameters, false, null);
Line 299: }
Line 300:
Line 301: private VdcReturnValueBase isModeAllowToRunAction(VdcActionType
actionType) {
--
To view, visit http://gerrit.ovirt.org/8669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912dcb
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
