Yair Zaslavsky has posted comments on this change.
Change subject: core: adding engine Maintenance and Prepare mode.(#868639)
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 115: --Handling Enables Host Load Balancing system.
Line 116: select
fn_db_add_config_value('EnableVdsLoadBalancing','true','general');
Line 117: select
fn_db_add_config_value('ENGINEEARLib','%JBOSS_HOME%/server/engine-slimmed/deploy/engine.ear','general');
Line 118: --Handling Engine maintenance mode
Line 119: select
fn_db_add_config_value('EngineMaintenanceMode','false','general');
As written in previous comment - I feel we should have a single Config entry
for engine mode with possible modes (ar previous comment I wrote that maybe in
the future we would like more than two options , and we already have more than
two).
Line 120: --Handling Engine prepare mode
Line 121: select fn_db_add_config_value('EnginePrepareMode','false','general');
Line 122: --Handling Mail User Domain
Line 123: select fn_db_add_config_value('ENMailDomain','','general');
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 384: ||
SessionDataContainer.getInstance().getUser(sessionId, parameters.getRefresh())
== null) {
Line 385: return
getErrorReturnQueryValue(VdcBllMessages.USER_IS_NOT_LOGGED_IN);
Line 386: }
Line 387: }
Line 388: if (Config.<Boolean>
GetValue(ConfigValues.EngineMaintenanceMode)) {
See previous comment in config_000 - if we decide to accept it, it will change
the code here as well.
Line 389: Class<CommandBase<? extends VdcActionParametersBase>>
clazz =
Line 390: CommandsFactory.getQueryClass(actionType.name());
Line 391: if
(clazz.isAnnotationPresent(DisableInMaintenanceMode.class)) {
Line 392: return
getErrorReturnQueryValue(VdcBllMessages.ENGINE_IS_RUNNING_IN_MAINTENANCE_MODE);
--
To view, visit http://gerrit.ovirt.org/8669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912dcb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
