Yair Zaslavsky has posted comments on this change. Change subject: core: adding engine Maintenance and Prepare mode.(#868639) ......................................................................
Patch Set 8: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java Line 299: } Line 300: Line 301: private VdcReturnValueBase isModeAllowToRunAction(VdcActionType actionType) { Line 302: EngineWorkingMode mode = Line 303: EngineWorkingMode.valueOf(Config.<String> GetValue(ConfigValues.EngineMode).toUpperCase()); Kublin - of course. I think we should add a support for this, but not in this patch. Line 304: switch (mode) { Line 305: case MAINTENANCEMODE: Line 306: return getErrorCommandReturnValue(VdcBllMessages.ENGINE_IS_RUNNING_IN_MAINTENANCE_MODE); Line 307: case PREPAREMODE: -- To view, visit http://gerrit.ovirt.org/8669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912dcb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches