Alon Bar-Lev has posted comments on this change. Change subject: core: Adds service configuration based on provided JBoss ......................................................................
Patch Set 4: (3 comments) thanks! much better, now, which subsystem are compatible so we can reduce the diff? https://gerrit.ovirt.org/#/c/40152/4/packaging/services/ovirt-engine/ovirt-engine.py File packaging/services/ovirt-engine/ovirt-engine.py: Line 58 Line 59 Line 60 Line 61 Line 62 you can add here more variable instead of update config. Line 220: break Line 221: elif 'WildFly' in line: Line 222: # Line: WildFly 8.1.0.Final "Kenny" Line 223: versionStr = parts[1] Line 224: break won't it better to parse it using regular expression? something like: [^\d]*(?P<major>\d+)\.(?P<minor>)\d+.(?P<fix>\d+).* Line 225: if versionStr is not None: Line 226: parts = versionStr.split('.') Line 227: major = parts[0] Line 228: minor = parts[1] Line 270: self._config.values.update({ Line 271: 'JBOSS_MAJOR': major, Line 272: 'JBOSS_MINOR': minor, Line 273: 'JBOSS_REVISION': revision, Line 274: }) it should not be part of config, better to use a different object/function for that. Line 275: Line 276: def daemonSetup(self): Line 277: Line 278: if os.geteuid() == 0: -- To view, visit https://gerrit.ovirt.org/40152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35f8a0c276735b9685affea1e068f6ef7298f8c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
