Liron Aravot has posted comments on this change. Change subject: core: prevent simultaneous reconstructs on the same pool(#845838) ......................................................................
Patch Set 12: mkublin, the issue that i'm trying to solve here is the mess with the updateVmInSpm, as in the flows currently we rely on that that if ReconstructMasterVDS command succeded, this command will as well (as we can't tell the vdsm side to rollback that operation, tell me please if i'm wrong). basically i guess that we can encounter the same issue from all sort of flows if we have exception after the vds command succeeds. even if i determine the exception and try to 'rollback' the operation by vds commands - i don't have garuntee that they will succeed and that i'll be able to recover as they might fail as well as they are totally separated commands. so yes, the issue is not only the race condition which may fail the updatevmovf, but at the moment there is not efficeint way to deal with that. the option that i see as possible is that it should be fixed on vdsm side (there is a bug about the same issue on vdsm so there will be fixed there as well) that there can't be two master domains (as there are on that scenario which makes ni sens) and spm start should success (it fails on this flow on getting hsm task command because of sanlock error i guess) and than if the spm won't be able to reach the master domain it will be reconstructed with proper values and domain list. or another option that the update vm in spm command will be executed in vdsm as part of the reconstruct vds command so both of them either succeed or fails, I -- To view, visit http://gerrit.ovirt.org/7982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dfb227b014af602e5bd1ab952d7c543992aa0f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
