Alon Bar-Lev has posted comments on this change.
Change subject: core: Add local configuration helper
......................................................................
Patch Set 6:
Hi,
I don't like the duplication between the logic at python and the logic at java,
for example the duplication of defaults.
I also don't like the need to synchronize java property files and plain shell
file.
The good at /etc/sysconfig/xxx is that it is a plain shell, so ${XXX} and
$(XXX) may be added... I know this is not the case of current implementation
but this patch locks us up in this mode.
I think the service should read the configuration, resolve the defaults and
provide it to the java porgram by any mean (environment, system properties,
temp properties file etc...).
This way we read the file using single implementation, resolve whatever needs
to be resolved (defaults, variables), and other programs can be fed with
whatever they need.
--
To view, visit http://gerrit.ovirt.org/6673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Anonymous Coward #1000055
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
