Juan Hernandez has posted comments on this change. Change subject: core: Add local configuration helper ......................................................................
Patch Set 4: Rebased and removed the capability to reload the configuration when it changes. Reading a properties files is certainly not complex, and it simplifies running the application: no need to provide environment variables or system properties. Some applications, like the notifier, or the engine-config and engine-manage-domains tools also need some of these properties, so using the same file already used by engine-service.py and centralizing/simplifying the access looks reasonable to me. What are the disadvantages that you see Alon? -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Anonymous Coward #1000055 Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
