Juan Hernandez has posted comments on this change. Change subject: core: Add local configuration helper ......................................................................
Patch Set 9: Previous incarnations of the patch had those methods where the called can provide the default values. Alon suggested to introduce a file with the default values in order to avoid having the defaults in the code, and I think it is a good thing. That is why I removed those methods. My reasoning was: if we remove the defaults from the code then we shouldn't have methods intended to have defaults in the code. However I am open to add back those methods if you think that they are needed or convenient. -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Anonymous Coward #1000055 Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
