Alon Bar-Lev has posted comments on this change. Change subject: core: Add local configuration helper ......................................................................
Patch Set 3: Hi, 1. I don't understand why we should support dynamic change of these variables. 2. I think that providing the required variables via the environment or system properties is simpler approach. There is no need to read this file within java. Alon. -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Anonymous Coward #1000055 Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
